DynamicIsland/DynamicIslandApp.swift (1)

952-971: 🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick win

Disk I/O in the deferred block still runs on the main thread.

DispatchQueue.main.async only pushes this to the next runloop turn — idleAnimationManager.initializeDefaultAnimations() and applySelectedAppIcon() still perform synchronous disk reads on the main thread, risking a hitch right after the first frame instead of during the (already deferred) launch path. ModelPricingManager.loadInitialPricing() in this same PR already establishes the pattern of offloading to Task.detached(priority: .utility) and hopping back to main only to publish results — worth applying the same approach here for consistency and to fully avoid a post-launch stall.

♻️ Sketch: move disk I/O off the main thread

 DispatchQueue.main.async { [weak self] in
     guard let self else { return }
-
-    // Disk I/O: load bundled idle animations off the critical launch path.
-    self.idleAnimationManager.initializeDefaultAnimations()
-
-    // Disk I/O: read Defaults + load the selected icon image, then apply it.
-    applySelectedAppIcon()
-
     // Instantiate always-on managers whose init only registers
     // observers/pollers...
     _ = self.bluetoothAudioManager
     _ = self.systemTimerBridge
     _ = self.lockScreenPanelManager
 }
+
+Task.detached(priority: .utility) { [weak self] in
+    self?.idleAnimationManager.initializeDefaultAnimations()
+    let icon = /* load selected icon image data here */
+    await MainActor.run {
+        applySelectedAppIcon(with: icon)
+    }
+}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@DynamicIsland/DynamicIslandApp.swift` around lines 952 - 971, Move the
disk-loading work in the deferred launch
closure—idleAnimationManager.initializeDefaultAnimations() and
applySelectedAppIcon()—into a Task.detached(priority: .utility), then hop back
to the main actor only for UI or manager updates that require main-thread
access. Preserve the existing ordering and behavior, while keeping the always-on
manager materialization on the main thread.

DynamicIsland/components/Shelf/Services/ThumbnailService.swift (1)

31-44: 🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick win

cacheKeys never shrinks when NSCache auto-evicts entries.

cacheKeys is only pruned in clearCache()/clearCache(for:); NSCache's own eviction (via countLimit/totalCostLimit/memory pressure) never notifies this set, so it grows unbounded for the process lifetime even though the underlying image cache is bounded.

♻️ Use NSCacheDelegate to keep cacheKeys in sync

-actor ThumbnailService {
+actor ThumbnailService: NSObject, NSCacheDelegate {
     static let shared = ThumbnailService()
 
     private let cache: NSCache<NSString, NSImage> = {
         let cache = NSCache<NSString, NSImage>()
         cache.countLimit = 200
         cache.totalCostLimit = 64 * 1024 * 1024 // 64 MB
         return cache
     }()
+
+    func cache(_ cache: NSCache<AnyObject, AnyObject>, willEvictObject obj: Any) {
+        // remove matching key from cacheKeys
+    }

Note: actors can't directly conform to NSCacheDelegate (which requires NSObjectProtocol); this likely needs a small NSObject delegate shim that forwards to the actor.

Also applies to: 45-68

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@DynamicIsland/components/Shelf/Services/ThumbnailService.swift` around lines
31 - 44, Update ThumbnailService’s cache bookkeeping so cacheKeys is removed
when NSCache evicts an object automatically. Add an NSObject-based
NSCacheDelegate shim, since the actor cannot conform directly, and have it
forward eviction callbacks to ThumbnailService; wire it to cache and keep
clearCache()/clearCache(for:) behavior unchanged.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes